Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ソング関連のe2eテストを追加 #1849

Merged
merged 10 commits into from
Feb 22, 2024
Merged

ソング関連のe2eテストを追加 #1849

merged 10 commits into from
Feb 22, 2024

Conversation

weweweok
Copy link
Contributor

内容

ソング関連のe2eテストを追加しました。

テストケース

  • 再生ボタンを押して再生できる
  • ノートを追加・削除できる
  • ダブルクリックでノートを編集できる

関連 Issue

@weweweok weweweok requested a review from a team as a code owner February 17, 2024 02:16
@weweweok weweweok requested review from y-chan and removed request for a team February 17, 2024 02:16
y-chan
y-chan approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

1点だけコメントしましたが、あってもなくてもいいかもです...!

tests/e2e/browser/song/song.test.ts Outdated Show resolved Hide resolved
@weweweok @y-chan
Update tests/e2e/browser/song/song.test.ts
92ed594 
Co-authored-by: Yuto Ashida <y-chan@y-chan.dev>
@weweweok
Copy link
Contributor Author

weweweok commented Feb 18, 2024 •
edited
Loading

レビューを反映しました。

Hiroshiba
Hiroshiba reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！

ちょっとこっちで書いてみてpushしてみるので @weweweok さんにそれ見てもらえると助かります！！

tests/e2e/browser/song/song.test.ts Outdated Show resolved Hide resolved
tests/e2e/browser/song/song.test.ts Outdated Show resolved Hide resolved
tests/e2e/browser/song/song.test.ts Outdated Show resolved Hide resolved
tests/e2e/browser/song/song.test.ts Outdated Show resolved Hide resolved
Hiroshiba
Hiroshiba approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！！

解説コメント書いてみました！
@weweweok 見ていただけると･･･！！

src/components/Sing/ScoreSequencer.vue Show resolved Hide resolved
src/components/Sing/ScoreSequencer.vue Show resolved Hide resolved
tests/e2e/browser/song/ソング.spec.ts Show resolved Hide resolved
tests/e2e/browser/song/ソング.spec.ts Outdated Show resolved Hide resolved
tests/e2e/browser/song/ソング.spec.ts Show resolved Hide resolved
@weweweok
Copy link
Contributor Author

ありがとうございます。
LGTMです！

細かいですが、関数を移動してみました。ご確認いただけると🙇‍♂

@Hiroshiba
Copy link
Member

ありがとうございます！　マージします！！

e2eテスト追加とても助かります。コードも良い感じだったと思います！
最近リファクタリング集用のissueを作ってみました。まだまだ少ないですが･･･。参考になれば幸いです！

@Hiroshiba Hiroshiba merged commit 6a51865 into VOICEVOX:main Feb 22, 2024
9 checks passed
@weweweok weweweok deleted the song-e2e-test branch February 22, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamachu yamachu yamachu left review comments

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weweweok @Hiroshiba @yamachu @y-chan